code review 支付问题

This commit is contained in:
YunaiV 2021-12-30 09:32:04 +08:00
parent 67aaf28832
commit 9a5f085369
2 changed files with 2 additions and 2 deletions

View File

@ -109,6 +109,7 @@ public class PayAppController {
// 得到所有的应用编号查出所有的通道 // 得到所有的应用编号查出所有的通道
Collection<Long> payAppIds = CollectionUtils.convertList(pageResult.getList(), PayAppDO::getId); Collection<Long> payAppIds = CollectionUtils.convertList(pageResult.getList(), PayAppDO::getId);
List<PayChannelDO> channels = channelService.getChannelListByAppIds(payAppIds); List<PayChannelDO> channels = channelService.getChannelListByAppIds(payAppIds);
// TODO @aquan可以基于 appId 简历一个 multiMap这样下面直接 get 到之后CollUtil buildSet 即可
Iterator<PayChannelDO> iterator = channels.iterator(); Iterator<PayChannelDO> iterator = channels.iterator();
// 得到所有的商户信息 // 得到所有的商户信息

View File

@ -181,10 +181,9 @@ public class PayAppServiceImpl implements PayAppService {
throw exception(PAY_APP_EXIST_TRANSACTION_ORDER_CANT_DELETE); throw exception(PAY_APP_EXIST_TRANSACTION_ORDER_CANT_DELETE);
} }
// 查看退款订单 // 查看退款订单
if (refundMapper.selectCount(appId, PayRefundStatusEnum.CREATE.getStatus()) > 0) { if (refundMapper.selectCount(appId, PayRefundStatusEnum.CREATE.getStatus()) > 0) {
throw exception(PAY_APP_EXIST_TRANSACTION_ORDER_CANT_DELETE); throw exception(PAY_APP_EXIST_TRANSACTION_ORDER_CANT_DELETE);
} }
} }
} }