From 444ba7982257e908acaa4e12a5cc481f4270b296 Mon Sep 17 00:00:00 2001 From: jason <2667446@qq.com> Date: Sun, 21 Nov 2021 22:33:42 +0800 Subject: [PATCH] =?UTF-8?q?=E4=BF=AE=E6=94=B9code=20review?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../pay/core/client/dto/PayNotifyDataDTO.java | 10 +++++++--- .../modules/pay/convert/order/PayRefundConvert.java | 3 ++- .../modules/shop/controller/ShopOrderController.java | 2 -- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/yudao-framework/yudao-spring-boot-starter-biz-pay/src/main/java/cn/iocoder/yudao/framework/pay/core/client/dto/PayNotifyDataDTO.java b/yudao-framework/yudao-spring-boot-starter-biz-pay/src/main/java/cn/iocoder/yudao/framework/pay/core/client/dto/PayNotifyDataDTO.java index 060a6bfd6..194a8348f 100644 --- a/yudao-framework/yudao-spring-boot-starter-biz-pay/src/main/java/cn/iocoder/yudao/framework/pay/core/client/dto/PayNotifyDataDTO.java +++ b/yudao-framework/yudao-spring-boot-starter-biz-pay/src/main/java/cn/iocoder/yudao/framework/pay/core/client/dto/PayNotifyDataDTO.java @@ -15,11 +15,15 @@ import java.util.Map; @Builder public class PayNotifyDataDTO { - // TODO @jason:使用 /** */ 的形式注释哈 - //返回的所有参数 + + /** + * HTTP 回调接口的 request body + */ private String body; - //form 格式的 data; + /** + * HTTP 回调接口 content type 为 application/x-www-form-urlencoded 的所有参数 + */ private Map params; } diff --git a/yudao-user-server/src/main/java/cn/iocoder/yudao/userserver/modules/pay/convert/order/PayRefundConvert.java b/yudao-user-server/src/main/java/cn/iocoder/yudao/userserver/modules/pay/convert/order/PayRefundConvert.java index 0a3ae4674..aeba347f9 100644 --- a/yudao-user-server/src/main/java/cn/iocoder/yudao/userserver/modules/pay/convert/order/PayRefundConvert.java +++ b/yudao-user-server/src/main/java/cn/iocoder/yudao/userserver/modules/pay/convert/order/PayRefundConvert.java @@ -8,7 +8,8 @@ import org.mapstruct.Mapper; import org.mapstruct.factory.Mappers; /** - * 支付退款 Convert // TODO @jason:类注释,和下面,有一个空行哈 + * 支付退款 Convert + * * @author jason */ @Mapper diff --git a/yudao-user-server/src/main/java/cn/iocoder/yudao/userserver/modules/shop/controller/ShopOrderController.java b/yudao-user-server/src/main/java/cn/iocoder/yudao/userserver/modules/shop/controller/ShopOrderController.java index f9d9a7660..25ebd6d28 100644 --- a/yudao-user-server/src/main/java/cn/iocoder/yudao/userserver/modules/shop/controller/ShopOrderController.java +++ b/yudao-user-server/src/main/java/cn/iocoder/yudao/userserver/modules/shop/controller/ShopOrderController.java @@ -57,8 +57,6 @@ public class ShopOrderController { .payOrderId(payOrderId).build()); } - - // TODO @jason:方法之间,空一行即可哈 @PostMapping("/pay-notify") @ApiOperation("支付回调") public CommonResult payNotify(@RequestBody @Valid PayNotifyOrderReqVO reqVO) {